Skip to content

Fix deprecation warnings in example/ sources#1933

Merged
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-deprecation-warnings-in-examples
Dec 13, 2024
Merged

Fix deprecation warnings in example/ sources#1933
oleksandr-pavlyk merged 1 commit intomasterfrom
fix-deprecation-warnings-in-examples

Conversation

@oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Dec 12, 2024 •
edited
Loading

Replace #include <CL/sycl.hpp> with #include <sycl/sycl.hpp> per deprecation warning

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

ndgrigorian
ndgrigorian reviewed Dec 12, 2024
View reviewed changes
@oleksandr-pavlyk oleksandr-pavlyk changed the title Fix deprecation warning in example/ Fix deprecation warnings in example/ sources Dec 12, 2024
ndgrigorian
ndgrigorian previously approved these changes Dec 12, 2024
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Dec 12, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_323 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

@coveralls
Copy link
Collaborator

coveralls commented Dec 12, 2024 •
edited
Loading

Coverage Status

coverage: 87.659%. remained the same
when pulling b0d44fa on fix-deprecation-warnings-in-examples
into 0bcd635 on master.

@github-actions
Copy link

github-actions bot commented Dec 12, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_324 ran successfully.
Passed: 895
Failed: 1
Skipped: 118

@oleksandr-pavlyk
Replace #include <CL/sycl.hpp> with #include <sycl/sycl.hpp> per depr…
b0d44fa 
…ecation warning

Include cstddef, add using std::size_t;
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the fix-deprecation-warnings-in-examples branch from 79d3cd6 to b0d44fa Compare December 13, 2024 00:50
@github-actions
Copy link

github-actions bot commented Dec 13, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310h93fe807_323 ran successfully.
Passed: 894
Failed: 2
Skipped: 118

ndgrigorian
ndgrigorian approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other warnings, especially in the Cython examples, but those can be left to a separate PR.

LGTM

@oleksandr-pavlyk
Copy link
Contributor Author

oleksandr-pavlyk commented Dec 13, 2024

There are other warnings, especially in the Cython examples, but those can be left to a separate PR.

I can not reproduce those warning locally though.

Log of local build 
building 'blackscholes._blackscholes_usm' extension
creating build
creating build/temp.linux-x86_64-cpython-312
creating build/temp.linux-x86_64-cpython-312/blackscholes
icpx -fsycl -fPIC -I./src -I/home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include -I/home/opavlyk/repos/dpctl/dpctl/include -I/home/opavlyk/mamba/envs/dev_dpctl/include/python3.12/.. -I/home/opavlyk/mamba/envs/dev_dpctl/include/python3.12 -c blackscholes/blackscholes.cpp -o build/temp.linux-x86_64-cpython-312/blackscholes/blackscholes.o -Wall -Wextra -fsycl -fno-fast-math
In file included from blackscholes/blackscholes.cpp:1303:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/arrayobject.h:5:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/ndarrayobject.h:12:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/ndarraytypes.h:1909:
/home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: "Using deprecated NumPy API, disable it with "          "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^
In file included from blackscholes/blackscholes.cpp:1330:
In file included from ./src/sycl_blackscholes.hpp:32:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device.hpp:24:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/functions.hpp:25:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/distribution_base.hpp:70:
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:141:35: warning: unused variable 'res_1' [-Wunused-variable]
  141 |                     std::uint32_t res_1, res_2;
      |                                   ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:141:42: warning: unused variable 'res_2' [-Wunused-variable]
  141 |                     std::uint32_t res_1, res_2;
      |                                          ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:253:31: warning: unused variable 'res_1' [-Wunused-variable]
  253 |                 std::uint32_t res_1, res_2;
      |                               ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:253:38: warning: unused variable 'res_2' [-Wunused-variable]
  253 |                 std::uint32_t res_1, res_2;
      |                                      ^~~~~
5 warnings generated.
In file included from blackscholes/blackscholes.cpp:1303:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/arrayobject.h:5:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/ndarrayobject.h:12:
In file included from /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/ndarraytypes.h:1909:
/home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/numpy/_core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: "Using deprecated NumPy API, disable it with "          "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-W#warnings]
   17 | #warning "Using deprecated NumPy API, disable it with " \
      |  ^
In file included from blackscholes/blackscholes.cpp:1330:
In file included from ./src/sycl_blackscholes.hpp:32:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device.hpp:24:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/functions.hpp:25:
In file included from /opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/distribution_base.hpp:70:
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:141:35: warning: unused variable 'res_1' [-Wunused-variable]
  141 |                     std::uint32_t res_1, res_2;
      |                                   ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:141:42: warning: unused variable 'res_2' [-Wunused-variable]
  141 |                     std::uint32_t res_1, res_2;
      |                                          ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:253:31: warning: unused variable 'res_1' [-Wunused-variable]
  253 |                 std::uint32_t res_1, res_2;
      |                               ^~~~~
/opt/intel/oneapi/mkl/2025.0/include/oneapi/mkl/rng/device/detail/uniform_impl.hpp:253:38: warning: unused variable 'res_2' [-Wunused-variable]
  253 |                 std::uint32_t res_1, res_2;
      |                                      ^~~~~
5 warnings generated.
creating build/lib.linux-x86_64-cpython-312
creating build/lib.linux-x86_64-cpython-312/blackscholes
icpx -fsycl -fPIC -fsycl -shared -fpic -fsycl-device-code-split=per_kernel build/temp.linux-x86_64-cpython-312/blackscholes/blackscholes.o -L/home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/.. -lsycl -lmkl_sycl -lmkl_intel_ilp64 -lmkl_tbb_thread -lmkl_core -ltbb -o build/lib.linux-x86_64-cpython-312/blackscholes/_blackscholes_usm.cpython-312-x86_64-linux-gnu.so -fPIC
copying build/lib.linux-x86_64-cpython-312/blackscholes/_blackscholes_usm.cpython-312-x86_64-linux-gnu.so -> blackscholes
Creating /home/opavlyk/mamba/envs/dev_dpctl/lib/python3.12/site-packages/blackscholes-usm.egg-link (link to .)
Adding blackscholes-usm 0.0.0 to easy-install.pth file

Installed /home/opavlyk/repos/dpctl/examples/cython/usm_memory
Processing dependencies for blackscholes-usm==0.0.0
Finished processing dependencies for blackscholes-usm==0.0.0

To be fixed in a separate PR.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 581b99f into master Dec 13, 2024
30 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-deprecation-warnings-in-examples branch December 13, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@oleksandr-pavlyk @coveralls @ndgrigorian